Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 )
Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load ...................................................................... Patch Set 1: (3 comments) Few nits, patch seems fine to me. http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/catalog/local/FailedLoadLocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/FailedLoadLocalTable.java: http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/catalog/local/FailedLoadLocalTable.java@33 PS1, Line 33: private TableLoadingException cause_; nit: final? http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/catalog/local/FailedLoadLocalTable.java@37 PS1, Line 37: cause nit: checkNotNull()? http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/service/MetadataOp.java@317 PS1, Line 317: || table instanceof FeIncompleteTable Can't we just override isLoaded() in FailedLoad..Table impl to make it less confusing? -- To view, visit http://gerrit.cloudera.org:8080/13557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia85d6b10669866dcc9f2bf7385a4775e483dd6b0 Gerrit-Change-Number: 13557 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 18:49:23 +0000 Gerrit-HasComments: Yes
