Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13557 )

Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to 
load
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13557/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13557/1//COMMIT_MSG@17
PS1, Line 17: This re-enables some tests that were previously disabled for
> Were you able to run the end-to-end tests with the local catalog enabled? I
I ran the kudu tests but didn't re-run the full suite. You think it's worth 
running a parameterized job and make sure I didn't regress something else? Is 
there an existing jenkins job that can easily be configured like that?


http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java
File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java:

http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@40
PS1, Line 40:  * Represents a table with incomplete metadata. The metadata may 
be incomplete because
> Trying to understand - does this IncompleteTable implementation get used in
yea I think this only gets used by the "v1" catalog. I'll add a comment.



--
To view, visit http://gerrit.cloudera.org:8080/13557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia85d6b10669866dcc9f2bf7385a4775e483dd6b0
Gerrit-Change-Number: 13557
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Fri, 07 Jun 2019 16:38:56 +0000
Gerrit-HasComments: Yes

Reply via email to