Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13670 )
Change subject: IMPALA-7734: Catalog and Statestore memz page shows useless memory ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13670/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13670/3//COMMIT_MSG@7 PS3, Line 7: > remove ... Done http://gerrit.cloudera.org:8080/#/c/13670/3/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/13670/3/be/src/util/default-path-handlers.cc@135 PS3, Line 135: if (mem_tracker != nullptr > It's less nested to do if (mem_tracker == nullptr) return; The DCHECK was removed because it was only guarding against null MemTracker. The decision whether to print the MemTracker metrics or not was added instead. I might be misunderstanding something. -- To view, visit http://gerrit.cloudera.org:8080/13670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a42434b98aec1d9e0be6ae52325049378fdde23 Gerrit-Change-Number: 13670 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 19:50:34 +0000 Gerrit-HasComments: Yes
