Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13670 )
Change subject: IMPALA-7734: Catalog and Statestore memz page shows useless memory ...................................................................... Patch Set 6: (3 comments) Thank you for the review Sahil. Please let me know if you would add additional docs/descriptions. http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.h File be/src/util/memusage-path-handlers.h: http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.h@33 PS6, Line 33: /// Adds a set of memory usage metrics to the webserver to display > Should add more docs, like what memory usage metrics are added and when. Added extra docs, the memory metric descriptions were moved to the Add* helper functions. http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.cc File be/src/util/memusage-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.cc@32 PS6, Line 32: void AddMemTracker(MemTracker* mem_tracker, > would be nice to add some docs to each of these methods Done http://gerrit.cloudera.org:8080/#/c/13670/6/be/src/util/memusage-path-handlers.cc@67 PS6, Line 67: > nit: extra new line? Done -- To view, visit http://gerrit.cloudera.org:8080/13670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a42434b98aec1d9e0be6ae52325049378fdde23 Gerrit-Change-Number: 13670 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 01 Jul 2019 09:05:19 +0000 Gerrit-HasComments: Yes
