Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13670 )
Change subject: IMPALA-7734: Catalog and Statestore memz page shows useless memory ...................................................................... Patch Set 4: (1 comment) For web UI changes, I generally find it useful to attach screenshots to the JIRA of what exactly changed. It helps document things more clearly. http://gerrit.cloudera.org:8080/#/c/13670/4/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/13670/4/be/src/util/default-path-handlers.cc@a134 PS4, Line 134: A nice thing about this DCHECK is that it prevented callers from inadvertently passing in a nullptr for mem_tracker, but now that we have removed the DCHECK, a client might accidentally pass in a nullptr when they didn't intend to. I would suggest re-factoring the code so there are multiple MemUsageHandler methods, one that takes in a mem_tracker, and one that does not. -- To view, visit http://gerrit.cloudera.org:8080/13670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a42434b98aec1d9e0be6ae52325049378fdde23 Gerrit-Change-Number: 13670 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 21:15:04 +0000 Gerrit-HasComments: Yes
