Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13803 )
Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13803/1/be/src/runtime/tuple.h File be/src/runtime/tuple.h: http://gerrit.cloudera.org:8080/#/c/13803/1/be/src/runtime/tuple.h@107 PS1, Line 107: that nit: maybe (that != nullptr) to be more explicit. OK to ignore -- To view, visit http://gerrit.cloudera.org:8080/13803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5b130848a3c8f11d9010b3378f4054a35e1612 Gerrit-Change-Number: 13803 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 15:27:15 +0000 Gerrit-HasComments: Yes
