Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 )
Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG@9 PS2, Line 9: include nit: start with http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h@472 PS2, Line 472: impala > I started off doing that, but I was checking before other transformations s I think I'm in favor of checking after the substitution. Do you think the additional allocations will be an issue? We could check whether the character after "impala" is a substitution character. The prometheus naming guide reads as it the "_" after the prefix was mandatory. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 28 Jul 2019 20:09:27 +0000 Gerrit-HasComments: Yes
