Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 )
Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG@9 PS2, Line 9: start w > nit: start with Done http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h@472 PS2, Line 472: impala > I think I'm in favor of checking after the substitution. Do you think the a Done. I doubt it's an issue, it adds a bit of overhead but should be pretty efficient with tcmalloc. The previous code was doing multiple reallocations while substituting the string. I think that would only result in an issue with prometheus namespaces if we called an impala metric something like impalathing.metric or impala#thing.metric, which would be weird. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 28 Jul 2019 21:21:11 +0000 Gerrit-HasComments: Yes
