Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13941
Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" ...................................................................... IMPALA-8799: prefix Prometheus metrics with "impala_" If the metric name does not already include "impala", we add the prefix. This makes it easier to separate Impala metrics from metrics from other systems that may also be present in prometheus. It is documented as a good practice, see: https://prometheus.io/docs/practices/naming/ Testing: * Added a targeted unit test for the name transformation. * Updated unit tests to reflect the new names. * Manually inspected /metrics_prometheus output. Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f --- M be/src/util/metrics-test.cc M be/src/util/metrics.cc M be/src/util/metrics.h M tests/webserver/test_web_pages.py 4 files changed, 159 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/13941/2 -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
