Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14032 )
Change subject: WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14032/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14032/1//COMMIT_MSG@7 PS1, Line 7: WIP: Can you add information about why is this in WIP state? The change seems complete to me with tests and without TODOs. http://gerrit.cloudera.org:8080/#/c/14032/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/14032/1/tests/metadata/test_hms_integration.py@893 PS1, Line 893: '(x int)' Can you also test what happens with partitioned tables? http://gerrit.cloudera.org:8080/#/c/14032/1/tests/metadata/test_hms_integration.py@902 PS1, Line 902: # Impala doesn't read column stats written by Hive. : self.client.execute('invalidate metadata %s' % table_name) : impala_stats = self.impala_all_column_stats(table_name) : assert '-1' == impala_stats['x']['#nulls'] : assert '-1' == impala_stats['x']['ndv'] It would be a change in design, but wouldn't it make sense to use stats written by Hive if there are no stats written by Impala? This could avoid breaking some existing workflows non partitioned tables. -- To view, visit http://gerrit.cloudera.org:8080/14032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782bda3891dee1281cfcd5cf8817aa1226217ad Gerrit-Change-Number: 14032 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2019 12:53:30 +0000 Gerrit-HasComments: Yes
