Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14032 )
Change subject: WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046. ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14032/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/14032/1/tests/metadata/test_hms_integration.py@893 PS1, Line 893: '(x int)' > Hive stores column stats for partitioned tables in PART_COL_STATS while Imp I would prefer to have that test here (I guess that it would't be a big change, only CREATE TABLE and INSERT would need to change. testing numRows would be also nice, even if it is not changed in this patch, as the test would become a good summary of Impala-Hive stat interop. I am ok with just mentioning these in a comment and probably doing it later. -- To view, visit http://gerrit.cloudera.org:8080/14032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782bda3891dee1281cfcd5cf8817aa1226217ad Gerrit-Change-Number: 14032 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2019 18:44:34 +0000 Gerrit-HasComments: Yes
