Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14032 )
Change subject: WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14032/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14032/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1366 PS2, Line 1366: table.getDb().getName(), table.getName(), col.getName(), "Impala"); > Probably best to make this a constant - HMS_STATS_ENGINE_NAME or whatever Done. Moved deleteTableColumnStatistics() wrapper to MetastoreShim. http://gerrit.cloudera.org:8080/#/c/14032/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/14032/1/tests/metadata/test_hms_integration.py@893 PS1, Line 893: '(x int)' > I would prefer to have that test here (I guess that it would't be a big cha Done http://gerrit.cloudera.org:8080/#/c/14032/2/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/14032/2/tests/metadata/test_hms_integration.py@876 PS2, Line 876: @pytest.mark.execute_serially > Does this actually need to be serial? It looks like it is only operating on True, done. -- To view, visit http://gerrit.cloudera.org:8080/14032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia782bda3891dee1281cfcd5cf8817aa1226217ad Gerrit-Change-Number: 14032 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2019 20:58:56 +0000 Gerrit-HasComments: Yes
