Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 )
Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/catalog/Catalog.java@732 PS2, Line 732: 0L Can this be called with txnId == -1? I would change this to <=0 or add a precondition for 0<=txnId http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1800 PS2, Line 1800: createion typo: creation http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1829 PS2, Line 1829: if (hmsPart.getParameters() != null) { : hmsPart.getParameters().remove(StatsSetupConst.COLUMN_STATS_ACCURATE); Do we have to alter the partition if COLUMN_STATS_ACCURATE was set? In a table that is generally written by Impala it will be never set and we could spare the alter partitions RPC. This optimization was implemented for INSERT in https://gerrit.cloudera.org/#/c/14037/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1838 PS2, Line 1838: unsetPartitionsColStats(table.getMetaStoreTable(), hmsPartitions, : writeId, txn.getId()); : } : // Remove COLUMN_STATS_ACCURATE property from the table. : unsetTableColStats(table.getMetaStoreTable(), txn.getId() Note that this will break when https://gerrit.cloudera.org/#/c/14066 is merged. http://gerrit.cloudera.org:8080/#/c/14071/2/testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test File testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test: http://gerrit.cloudera.org:8080/#/c/14071/2/testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test@96 PS2, Line 96: truncate table pt; Shouldn't this have a RESULTS section? -- To view, visit http://gerrit.cloudera.org:8080/14071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic749b7f27da157e1c0ebf9b7e9b6ee09afad122a Gerrit-Change-Number: 14071 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2019 19:16:41 +0000 Gerrit-HasComments: Yes
