Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 )
Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14071/3/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/14071/3/fe/src/main/java/org/apache/impala/catalog/Catalog.java@705 PS3, Line 705: public void lockTableInTransaction(String dbName, String tableName, long txnId, > We could get the caller to pass in a Transaction object, I think I'd prefer Done. I kept the long for lockTableInternal() because it can take 0L as no transaction, and it's also a private method. http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14071/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1838 PS2, Line 1838: unsetPartitionsColStats(table.getMetaStoreTable(), hmsPartitions, : writeId, txn.getId()); : } : // Remove COLUMN_STATS_ACCURATE property from the table. : unsetTableColStats(table.getMetaStoreTable(), txn.getId() > Thanks for the notice, will fix it in a separate rebase commit. Done. -- To view, visit http://gerrit.cloudera.org:8080/14071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic749b7f27da157e1c0ebf9b7e9b6ee09afad122a Gerrit-Change-Number: 14071 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 23 Aug 2019 16:03:30 +0000 Gerrit-HasComments: Yes
