Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 )
Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14071/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14071/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1850 PS4, Line 1850: try (MetaStoreClient msClient = catalog_.getMetaStoreClient()) > The common pattern seems to be to hold only one msClient at the same time i I agree that it is something that we should clean up. The MetastoreShim methods usually take an IMetaStoreClient, methods from other classes access to a Catalog object so they can just ask another client from the pool. Maybe we should always pass around the pool? The cleanup might require quite a few changes so I think we should do it in a separate jira. -- To view, visit http://gerrit.cloudera.org:8080/14071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic749b7f27da157e1c0ebf9b7e9b6ee09afad122a Gerrit-Change-Number: 14071 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Aug 2019 13:47:27 +0000 Gerrit-HasComments: Yes
