David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14181 )
Change subject: IMPALA-1071: Distributable python package for impala-shell ...................................................................... Patch Set 4: (2 comments) > Patch Set 3: Code-Review+1 > > (2 comments) > > Thanks for making this! Gladly! Hopefully customers find it useful. In patch 4, I also added a restriction on the python version in setup.py. $ pip install dist/impala_shell-3.3.0.dev20190910115339.tar.gz Processing ./dist/impala_shell-3.3.0.dev20190910115339.tar.gz ERROR: Package 'impala-shell' requires a different Python: 3.5.2 not in '<3.0.0' http://gerrit.cloudera.org:8080/#/c/14181/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/14181/3/shell/impala_client.py@1120 PS3, Line 1120: th > nit: typo Done http://gerrit.cloudera.org:8080/#/c/14181/3/shell/packaging/make_python_package.sh File shell/packaging/make_python_package.sh: http://gerrit.cloudera.org:8080/#/c/14181/3/shell/packaging/make_python_package.sh@37 PS3, Line 37: c > nit: remove space Done -- To view, visit http://gerrit.cloudera.org:8080/14181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c745bddddf6a16f0c039430152745a2f00e044 Gerrit-Change-Number: 14181 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 19:05:11 +0000 Gerrit-HasComments: Yes
