David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14181 )
Change subject: IMPALA-1071: Distributable python package for impala-shell ...................................................................... Patch Set 5: (4 comments) There's still one more comment to address that will come in the next patch, along with a few changes that I realized were needed as I tried to prepare the public alpha release. http://gerrit.cloudera.org:8080/#/c/14181/4/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/14181/4/shell/impala_client.py@1101 PS4, Line 1101: > haphazardly Done http://gerrit.cloudera.org:8080/#/c/14181/4/shell/impala_client.py@1103 PS4, Line 1103: LA-6808. > principal Done http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/__init__.py File shell/packaging/__init__.py: http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/__init__.py@1 PS4, Line 1: #!/usr/bin/env python > It would be better to add the copyright header here instead of adding this Done http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/setup.py File shell/packaging/setup.py: http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/setup.py@128 PS4, Line 128: python_requires='>2.6, <3.0.0', > Should this also be > 2.6? Done -- To view, visit http://gerrit.cloudera.org:8080/14181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c745bddddf6a16f0c039430152745a2f00e044 Gerrit-Change-Number: 14181 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2019 17:23:00 +0000 Gerrit-HasComments: Yes
