Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14181 )
Change subject: IMPALA-1071: Distributable python package for impala-shell ...................................................................... Patch Set 4: (5 comments) Had a few minor comments. Looks great overall http://gerrit.cloudera.org:8080/#/c/14181/4/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/14181/4/shell/impala_client.py@1101 PS4, Line 1101: hapahazrdly haphazardly http://gerrit.cloudera.org:8080/#/c/14181/4/shell/impala_client.py@1103 PS4, Line 1103: principle principal http://gerrit.cloudera.org:8080/#/c/14181/4/shell/make_shell_tarball.sh File shell/make_shell_tarball.sh: http://gerrit.cloudera.org:8080/#/c/14181/4/shell/make_shell_tarball.sh@132 PS4, Line 132: # Finally, make a python package that can be installed independently I think it would be better to make this a CMake target that depends on shell_tarball. You could add it to MAKE_TARGETS in buildall.sh or the "tarballs" CMake target to ensure its built as part of our jobs. I think generally it's better to move more of the build logic into CMake with explicit dependencies rather than using shell scripts to sequence it. http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/__init__.py File shell/packaging/__init__.py: http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/__init__.py@1 PS4, Line 1: #!/usr/bin/env python It would be better to add the copyright header here instead of adding this to rat_exclude_files http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/setup.py File shell/packaging/setup.py: http://gerrit.cloudera.org:8080/#/c/14181/4/shell/packaging/setup.py@128 PS4, Line 128: python_requires='<3.0.0', Should this also be > 2.6? -- To view, visit http://gerrit.cloudera.org:8080/14181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c745bddddf6a16f0c039430152745a2f00e044 Gerrit-Change-Number: 14181 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 11 Sep 2019 20:51:40 +0000 Gerrit-HasComments: Yes
