Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile ...................................................................... Patch Set 3: (5 comments) > Patch Set 3: > > (2 comments) . I need the number only to change to float, so I need the return to be 2.52 in your case. . When the Probe is 0 or 18, there is no dot. http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h@532 PS3, Line 532: HashTableStatsProfile > what exactly is this struct suppose to encapsulate? would be good to add so Done http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h@534 PS3, Line 534: RuntimeProfile *hashtable_profile = nullptr; > nit: RuntimeProfile* hasbtable_profile = nullptr; Done http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@677 PS3, Line 677: a > nit: an Done http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@688 PS3, Line 688: execute_query > should assert that the query was actually successful: Done http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@691 PS3, Line 691: > nit: extra space Done -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Sep 2019 19:51:47 +0000 Gerrit-HasComments: Yes
