Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile ...................................................................... Patch Set 3: (6 comments) Patch 4 addresses review issues. http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h@643 PS3, Line 643: // Create profile and counters for HashTable stats and add to parent profile. : /// Returns a HashTableStatsProfile object. > would be good to document that this actually makes a child profile called " Done http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h@645 PS3, Line 645: CreateAndAddToProfile > I'd suggest returning a unique_ptr, and using an unique_ptr to store it - t Done http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h@651 PS3, Line 651: StatsCountersAdd > Not sure I follow, once the HashTable is closed, the internal counters are But not all the close of hashtable should trigger the counters adding. I add more comments to explain the related case. http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@677 PS3, Line 677: a > Done Done http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@688 PS3, Line 688: execute_query > Done Done http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@691 PS3, Line 691: > Done Done -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Sep 2019 13:24:48 +0000 Gerrit-HasComments: Yes
