Hello Attila Jeges, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14291
to look at the new patch set (#2).
Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
......................................................................
IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
This patch adds additional datetime format tokens on top of what was
introduced with Milestone 1 (IMPALA-8703).
The tokens introduced:
- Free text token: Surrounded by double quotes, a free text section
can be given in the format where the same text is expected in the
input without the surrounding double quotes.
- FX modifier: This modifier has to be given at the beginning of the
format and is valid for the whole format.
In a string to datetime conversion this forces strict separator
matching and expects all the tokens in the input to have the same
length as their maximum length. E.g. A month has to be of length 2
prefixed by zero if needed.
This is the default in a datetime to string conversion.
- FM modifier: This modifier affects only the following token and
overrides the FX modifier. Using this the value of a token can be
shorter than the max length if followed by a separator.
E.g. 1-digit month, less than 4-digit year, etc. This is the
default behaviour in a string to datetime conversion.
Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855
---
M be/src/runtime/date-parse-util.cc
M be/src/runtime/datetime-iso-sql-format-parser.cc
M be/src/runtime/datetime-iso-sql-format-parser.h
M be/src/runtime/datetime-iso-sql-format-tokenizer.cc
M be/src/runtime/datetime-iso-sql-format-tokenizer.h
M be/src/runtime/datetime-parser-common.cc
M be/src/runtime/datetime-parser-common.h
M be/src/runtime/timestamp-parse-util.cc
M tests/query_test/test_cast_with_format.py
9 files changed, 482 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14291/2
--
To view, visit http://gerrit.cloudera.org:8080/14291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855
Gerrit-Change-Number: 14291
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
