Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 )
Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py@578 PS2, Line 578: test_text_token > Thanks for spotting this. The code is not really prepared to handle backsla Update: I did some adjustments to include backslash in the format and input. You can now do so and even include some special chars like '\n' or '\t'. Note, that it's still not feasible to go super wild with the backslashes and include multiple ones after each other. I'm not sure if this is worth putting more efforts into because I don't see any real life scenarios where that would be needed. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2019 12:58:57 +0000 Gerrit-HasComments: Yes
