Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 )
Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py@578 PS2, Line 578: test_text_token I'm confused about how a backslash character should be represented inside the text format token: This works: select cast('1985 \ 11-28' as date format 'YYYY" \ "MM-DD'); and this works too: select cast('1985 \ 11-28' as date format 'YYYY" \\\\\\\\\\ "MM-DD'); Is this the expected behavior or a bug? http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py@580 PS2, Line 580: ''' : r''' You can probably remove these from the end of the L580 and the beginning of L581, here and elsewhere in the method. These kind of strings in python may span multiple lines. r'''select cast('1985-11-19T01:02:03Z' as timestamp format 'YYYY-MM-DD"T"HH24:MI:SS"Z"')''' The \n character will become part of the string, but in this case it probably won't be a problem. -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2019 17:41:06 +0000 Gerrit-HasComments: Yes
