Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 )
Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py@1337 PS1, Line 1337: sleep(30) # Wait for the 'lineitem' scan to complete > Will number of a in-flight fragments a more reliable metric to wait on ? The goal of the test is to actually validate that NumCompletedBackends is incremented. However, I removed the sleep and replaced it with an assert_eventually which I think is more reliable. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2019 23:44:16 +0000 Gerrit-HasComments: Yes
