Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 )
Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py@1337 PS1, Line 1337: sleep(30) # Wait for the 'lineitem' scan to complete > The test itself is timing dependent, so I don't think we can get out of usi Not sure if there is any misunderstanding here. I understand the purpose of the test is to validate that NumCompletedBackends == 1 and I am not suggesting you to remove that check. Instead, my suggestion is that the test should wait on a logical condition in which NumCompletedBackends is expected to be 1 before checking NumCompletedBackends == 1 in the query profile. My understanding is that this condition should happen once all instances of F01 reach the "FINISHED" state. Anyhow, this is just a minor point but I think timing dependent tests are usually prone to flakiness so avoiding that if possible would be great. Please feel free to grab me and discuss this offline if it's still not clear. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Oct 2019 23:38:25 +0000 Gerrit-HasComments: Yes
