Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 )
Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py@1337 PS1, Line 1337: # Once the 'lineitem' scan completes, NumCompletedBac > Yeah, maybe discussing in person is best, will find you tomorrow. Fair enough. I suppose all functions waiting for certain condition to become true has a timeout by default so there is no getting away from using some sort of timeout to avoid the test from hanging forever. May be safer to bump the timeout to a higher value such as 60s. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Oct 2019 18:14:32 +0000 Gerrit-HasComments: Yes
