Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14339 )
Change subject: IMPALA-8899, IMPALA-8898: Add cookie support to the webui ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14339/4/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/14339/4/be/src/util/webserver-test.cc@379 PS4, Line 379: if (RunShellProcess("curl --version", &curl_output) > Right, I would prefer to get this patch in and worry about the toolchain st Ok, makes sense. Install curl in precommit seems like a good idea. -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2019 19:09:17 +0000 Gerrit-HasComments: Yes
