Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14339 )
Change subject: IMPALA-8899, IMPALA-8898: Add cookie support to the webui ...................................................................... IMPALA-8899, IMPALA-8898: Add cookie support to the webui This patches takes the machinery for generating and checking cookies for authentication that was added in IMPALA-8584 and applies to the webui. It also fixes an issue where some clients, for example Knox, may return the cookie value surrounded by "". It adds metrics for both SPNEGO auth success/failure and cookie auth success/failure to the webserver. This patch also fixes IMPALA-8898 by returning an empty cookie with a Max-Age of 0 on requests where an invalid cookie was provided to indicate to the client that the cookie should be deleted. Testing: - Added a test that uses curl to access the webserver with SPNEGO enabled while storing and using cookies. This test only runs when curl is present and has the necessary options enabled, which is generally not the case in our automated testing runs. Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Reviewed-on: http://gerrit.cloudera.org:8080/14339 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Thomas Tauber-Marshall <tmarsh...@cloudera.com> --- M be/src/catalog/catalogd-main.cc M be/src/rpc/authentication.cc M be/src/rpc/cookie-util.cc M be/src/rpc/cookie-util.h M be/src/runtime/exec-env.cc M be/src/statestore/statestored-main.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M common/thrift/metrics.json M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 11 files changed, 325 insertions(+), 166 deletions(-) Approvals: Impala Public Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
