Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14339 )

Change subject: IMPALA-8899, IMPALA-8898: Add cookie support to the webui
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

carrying forward

http://gerrit.cloudera.org:8080/#/c/14339/4/be/src/util/webserver-test.cc
File be/src/util/webserver-test.cc:

http://gerrit.cloudera.org:8080/#/c/14339/4/be/src/util/webserver-test.cc@379
PS4, Line 379: 
> Ok, makes sense. Install curl in precommit seems like a good idea.
I verified that curl is already installed in our precommit environment and this 
test runs successfully there



--
To view, visit http://gerrit.cloudera.org:8080/14339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4
Gerrit-Change-Number: 14339
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 09 Oct 2019 00:26:11 +0000
Gerrit-HasComments: Yes

Reply via email to