Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 )
Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/14291/3/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/14291/3/tests/query_test/test_cast_with_format.py@724 PS3, Line 724: 'format 'YYYY-"some \ text"MM-DD' > I'm confused about the usage of backslash in this format string and the for Well, being honest I got also confused by all this escaping and such :) Anyway the first bullet point seems correct for me and in the second the output shouldn't contain a backslash. Will do the change to work accordingly. http://gerrit.cloudera.org:8080/#/c/14291/3/tests/query_test/test_cast_with_format.py@730 PS3, Line 730: s > Probably the apostrophe can be removed for clarity. I assume the - separato Done http://gerrit.cloudera.org:8080/#/c/14291/3/tests/query_test/test_cast_with_format.py@731 PS3, Line 731: 'YYYY-"\some text"MM-DD' > Again, the backslash is used here to escape the s character right? See above http://gerrit.cloudera.org:8080/#/c/14291/3/tests/query_test/test_cast_with_format.py@735 PS3, Line 735: '1985-some text12-08' > Please use a raw string here too, to make it explicit if the backslash mean Done -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 09 Oct 2019 09:45:27 +0000 Gerrit-HasComments: Yes
