Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 )
Change subject: IMPALA-9030: Handle translated external Kudu tables ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@120 PS2, Line 120: isSynchronizedTable(tabl > synchronized comes from whether a table is kept in-snyc with HMS in Kudu HM I agree the naming could be useful. I synced up with Hao offline to understand what it means when we say synchronized Kudu tables. I updated the change to rename this method to synchronized table. http://gerrit.cloudera.org:8080/#/c/14397/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/14397/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@142 PS3, Line 142: isExternalTable(msTbl) && !Boolean : .parseBoolean(msTbl.getParameters().get(TBL_PROP_EXTERNAL_TABLE_PURGE)); > This should be reversed now, since a synchronized table is either managed o yeah thats right. I had noticed it but forgot to publish the patchset which makes the appropriate changes. http://gerrit.cloudera.org:8080/#/c/14397/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@151 PS3, Line 151: public static boolean isExternalTable(org.apache.hadoop.hive.metastore.api.Table msTbl) { > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/14397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324523361c923b7d291cb4d0f1028b1a5b653b36 Gerrit-Change-Number: 14397 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2019 17:26:04 +0000 Gerrit-HasComments: Yes
