Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 )
Change subject: IMPALA-9030: Handle translated external Kudu tables ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@117 PS2, Line 117: managed Kudu table Update the comment to reflect the change and else where. http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@120 PS2, Line 120: isExternallyManagedTable > logically its doing the same right. It is checking if this table is not ext Yeah, I guess I would prefer the naming 'isSynchronizedTable' as it is more clear and less misleading than 'isExternallyManagedTable'. http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@131 PS2, Line 131: HMS nit: missing period. http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/catalog/Table.java@157 PS2, Line 157: external table nit: external table. -- To view, visit http://gerrit.cloudera.org:8080/14397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324523361c923b7d291cb4d0f1028b1a5b653b36 Gerrit-Change-Number: 14397 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2019 23:35:11 +0000 Gerrit-HasComments: Yes
