Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 )
Change subject: IMPALA-9030: Handle translated external Kudu tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@120 PS2, Line 120: isExternallyManagedTable > Just curious to know if "synchronized table" is a valid Kudu concept? When synchronized comes from whether a table is kept in-snyc with HMS in Kudu HMS sync feature. I don't think that terminology needs to be used here. But a terminology change would be useful to avoid confusion. I think the confusion comes from the fact that external and managed are existing concepts on their own and "externallyManaged" uses both the terms. It would be useful to have a term which describes a table that is tightly coupled like managed tables or external purge tables are. I don't think it's critical to fix/change this now. With 2 +1s, this just needs and Impala committer to review and provide feedback. -- To view, visit http://gerrit.cloudera.org:8080/14397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324523361c923b7d291cb4d0f1028b1a5b653b36 Gerrit-Change-Number: 14397 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Oct 2019 19:42:16 +0000 Gerrit-HasComments: Yes
