Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 )
Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode ...................................................................... Patch Set 8: (4 comments) The patch is good to go from my side. I had some questions and some nits below. http://gerrit.cloudera.org:8080/#/c/14307/8/be/src/util/impalad-metrics.cc File be/src/util/impalad-metrics.cc: http://gerrit.cloudera.org:8080/#/c/14307/8/be/src/util/impalad-metrics.cc@220 PS8, Line 220: 0 Should this be initialized to -1? http://gerrit.cloudera.org:8080/#/c/14307/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14307/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@763 PS8, Line 763: catalog.setCatalog(new TCatalog(catalogServiceId_, ctx.lastResetStartVersion)); > I finally found that we should at least add the updated dbs and tables into I see. Thanks for exploring this suggestion. http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_concurrent_ddls.py@152 PS11, Line 152: : : : : : : : Can you add a comment explaining why these are acceptable errors? its not very clear to me. http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_local_catalog.py@50 PS11, Line 50: get_min_catalog_object_version Was this function not useful? https://github.com/apache/impala/blob/master/tests/common/impala_service.py#L82 -- To view, visit http://gerrit.cloudera.org:8080/14307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib61a7ab1ffa062620ffbc2dadc34bd7a8ca9e549 Gerrit-Change-Number: 14307 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Nov 2019 01:45:53 +0000 Gerrit-HasComments: Yes
