Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 )
Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode ...................................................................... Patch Set 11: (3 comments) Thanks for your comments, Vihang! Changes in the new patch: 1) Found and fixed IMPALA-9136 2) Rename all min_catalog_object_version stuffs to catalog_object_version_lower_bound. 3) Add more logging to better diagnosing catalog version issues. http://gerrit.cloudera.org:8080/#/c/14307/8/be/src/util/impalad-metrics.cc File be/src/util/impalad-metrics.cc: http://gerrit.cloudera.org:8080/#/c/14307/8/be/src/util/impalad-metrics.cc@220 PS8, Line 220: _ > Should this be initialized to -1? I think it's ok to be 0 since no catalog objects will have catalog version = -1. It keeps the invariant that all cached catalog object versions >= 0. http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_concurrent_ddls.py@152 PS11, Line 152: if "CatalogException: Table" in err and \ : "was modified while operation was in progress, aborting execution" in err: : return True : if sync_ddl and "Couldn't retrieve the catalog topic version for the SYNC_DDL " \ : "operation after 5 attempts.The operation has been successfully " \ : "executed but its effects may have not been broadcast to all the " \ : "coordinators." in err: : return True > Can you add a comment explaining why these are acceptable errors? its not v Sure, added the comments. I actually find two bugs (IMPALA-9135 and IMPALA-9136) when digged deeper. IMPALA-9135 is simple so I fixed it by the way in this patch. Thanks for raising this! http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/14307/11/tests/custom_cluster/test_local_catalog.py@50 PS11, Line 50: get_min_catalog_object_version > Was this function not useful? https://github.com/apache/impala/blob/master/ Nice find! I missed it... -- To view, visit http://gerrit.cloudera.org:8080/14307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib61a7ab1ffa062620ffbc2dadc34bd7a8ca9e549 Gerrit-Change-Number: 14307 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Nov 2019 04:03:35 +0000 Gerrit-HasComments: Yes
