Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 )
Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI ...................................................................... Patch Set 10: (1 comment) I think it will be useful to also add logs in cases where total loading time took abnormally long (say 5 seconds, for lack of a better estimate of what is a good loading time). This would be helpful to find out relevant time-windows in logs for a given table when loading was slower. rest looks good to me. http://gerrit.cloudera.org:8080/#/c/14600/10/www/scripts/util.js File www/scripts/util.js: http://gerrit.cloudera.org:8080/#/c/14600/10/www/scripts/util.js@52 PS10, Line 52: if (!hour && value >= 1000) { : re += (Math.floor(value / 1000) + "s"); : value = value % 1000; : second = true; : } More comments will be helpful to understand this function better. Why do we need !hour here? If the input is 36001000 then what is the output? -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 10 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Nov 2019 23:30:57 +0000 Gerrit-HasComments: Yes
