Jiawei Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 )
Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI ...................................................................... Patch Set 11: (2 comments) Hi Vihang, thanks for the feedback. Let me know if you need more clarification. http://gerrit.cloudera.org:8080/#/c/14600/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/14600/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@993 PS11, Line 993: "warning threshold. Time: " + load_time_duration + " ns"); I implemented a PrettyPrint() function on front-end in IMPALA-9110. Will refactor the time printing in that ticket. http://gerrit.cloudera.org:8080/#/c/14600/10/www/scripts/util.js File www/scripts/util.js: http://gerrit.cloudera.org:8080/#/c/14600/10/www/scripts/util.js@52 PS10, Line 52: // if hour is true, the time is large enough and we should : // ignore the remaining time on second level : if (!hour && value >= 1000) { : re += (Math.floor(value / 1000) + "s"); : > More comments will be helpful to understand this function better. Why do we The output for this will be 10h. I am using the same logic as https://github.com/apache/impala/blob/288abf10f6142ae6cb02329604805a9a1dcc804f/be/src/util/pretty-printer.h#L249 I think if "hour" is true, then the time will be large enough and we should ignore the seconds? That should be the original idea. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 11 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Nov 2019 05:58:19 +0000 Gerrit-HasComments: Yes
