Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 )
Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/14600/10/www/scripts/util.js File www/scripts/util.js: http://gerrit.cloudera.org:8080/#/c/14600/10/www/scripts/util.js@52 PS10, Line 52: if (!hour && value >= 1000) { : re += (Math.floor(value / 1000) + "s"); : value = value % 1000; : second = true; : } > The output for this will be 10h. I am using the same logic as https://githu ah, okay. Thanks for the explanation. Although, I think it definitely makes it clearer if we add a comment saying that. Not a blocker though. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 10 Gerrit-Owner: Jiawei Wang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiawei Wang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2019 17:56:56 +0000 Gerrit-HasComments: Yes
