Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 )
Change subject: IMPALA-9128: improved diagnostics for slow data stream RPCs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14662/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/14662/2/be/src/runtime/krpc-data-stream-sender.cc@374 PS2, Line 374: LOG(INFO) << "Long delay waiting for RPC to " << TNetworkAddressToString(address_) Doing this inside the loop does result in quite a lot of log spam, I should probably move it outside the loop or rate-limit it. -- To view, visit http://gerrit.cloudera.org:8080/14662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I258ac91b9fbbdbc86d0e8091c34f511f8957c4cd Gerrit-Change-Number: 14662 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2019 20:28:55 +0000 Gerrit-HasComments: Yes
