Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 )
Change subject: IMPALA-9128: part 1: log on slow data stream RPCs ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14662/1/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/14662/1/be/src/runtime/krpc-data-stream-sender.h@225 PS1, Line 225: RuntimeProfile::SummaryStatsCounter* recvr_time_stats_ = nullptr; > I think you're right on that one - it looks like the timer starts when the Looks like you've decided to tackle this by leaving 'receiver_latency_ns' alone and doing the tracing in a follow up patch? That works for me http://gerrit.cloudera.org:8080/#/c/14662/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/14662/4/be/src/runtime/krpc-data-stream-sender.cc@374 PS4, Line 374: if (IsSlowRpc(elapsed_time_ns)) { Are there rpcs that this will log for that we wouldn't have noticed were slow in ...CompleteCB? -- To view, visit http://gerrit.cloudera.org:8080/14662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I258ac91b9fbbdbc86d0e8091c34f511f8957c4cd Gerrit-Change-Number: 14662 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2019 18:48:02 +0000 Gerrit-HasComments: Yes
