Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14662 )
Change subject: IMPALA-9128: part 1: log on slow data stream RPCs ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14662/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/14662/4/be/src/runtime/krpc-data-stream-sender.cc@374 PS4, Line 374: if (IsSlowRpc(elapsed_time_ns)) { > Are there rpcs that this will log for that we wouldn't have noticed were sl I don't think so, I was thinking that it might be useful to directly track the amount of time spent waiting, since if this triggers it proves that it blocked the sender thread (in theory a slow RPC might not block the sender if the sender if running very slow). But I guess that's probably not super-useful, since a slow RPC is likely to be a symptom of something regardless - I can remove it if you think it's not worth the extra noise. -- To view, visit http://gerrit.cloudera.org:8080/14662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I258ac91b9fbbdbc86d0e8091c34f511f8957c4cd Gerrit-Change-Number: 14662 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2019 18:56:56 +0000 Gerrit-HasComments: Yes
