Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 )
Change subject: IMPALA-8205: Support number of true and false statistics for boolean column ...................................................................... Patch Set 1: (8 comments) Thanks for fixing so much tests! I did a first round review and this patch makes sense to me. Will look into it deeper later. http://gerrit.cloudera.org:8080/#/c/14666/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14666/1//COMMIT_MSG@9 PS1, Line 9: This change compute the real number of true and false statistics information for boolean columns; Before this, impala used to set numTrues and numFalses to hardcoded -1 to indicate that its statistics is missing; Please wrap the commit message at 72 characters per line and replace ";" with "." http://gerrit.cloudera.org:8080/#/c/14666/1/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/14666/1/be/src/exec/catalog-op-executor.cc@286 PS1, Line 286: , nit: . http://gerrit.cloudera.org:8080/#/c/14666/1/be/src/exec/incr-stats-util.cc File be/src/exec/incr-stats-util.cc: http://gerrit.cloudera.org:8080/#/c/14666/1/be/src/exec/incr-stats-util.cc@164 PS1, Line 164: num_trues num_new_trues? http://gerrit.cloudera.org:8080/#/c/14666/1/be/src/exec/incr-stats-util.cc@165 PS1, Line 165: num_falses num_new_falses? http://gerrit.cloudera.org:8080/#/c/14666/1/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/14666/1/common/thrift/CatalogObjects.thrift@172 PS1, Line 172: required Shoule this be optional? It's just set for boolean column. http://gerrit.cloudera.org:8080/#/c/14666/1/common/thrift/CatalogObjects.thrift@198 PS1, Line 198: required optional too? http://gerrit.cloudera.org:8080/#/c/14666/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/14666/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@512 PS1, Line 512: numTrues nit: numTrues_ http://gerrit.cloudera.org:8080/#/c/14666/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@513 PS1, Line 513: numFalses nit: numFalses_ -- To view, visit http://gerrit.cloudera.org:8080/14666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I991bee8e7fdc644d908289f5fe2ee8032cc2c431 Gerrit-Change-Number: 14666 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2019 23:32:10 +0000 Gerrit-HasComments: Yes
