Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 )
Change subject: IMPALA-8205: Support number of true and false statistics for boolean column ...................................................................... Patch Set 3: (4 comments) Sorry to be late... I can give a +1 after some minor changes. Will ask someone else to have a look too. http://gerrit.cloudera.org:8080/#/c/14666/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14666/3//COMMIT_MSG@11 PS3, Line 11: ; nit: . http://gerrit.cloudera.org:8080/#/c/14666/3/be/src/exec/incr-stats-util.cc File be/src/exec/incr-stats-util.cc: http://gerrit.cloudera.org:8080/#/c/14666/3/be/src/exec/incr-stats-util.cc@249 PS3, Line 249: VLOG(1) << "update statistics value is " << col_stats_schema.columns[i].columnName This looks too verbose. Change to VLOG(3) to be consistent with line 336? http://gerrit.cloudera.org:8080/#/c/14666/3/be/src/exec/incr-stats-util.cc@318 PS3, Line 318: VLOG(1) << "update intermediate value for column " << col_name << "," change to VLOG(3) too? http://gerrit.cloudera.org:8080/#/c/14666/3/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/14666/3/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@39 PS3, Line 39: import org.slf4j.LoggerFactory; Unused imports? -- To view, visit http://gerrit.cloudera.org:8080/14666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I991bee8e7fdc644d908289f5fe2ee8032cc2c431 Gerrit-Change-Number: 14666 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2019 09:38:23 +0000 Gerrit-HasComments: Yes
