Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14813 )
Change subject: IMPALA-9162: Do not apply inferred predicate to outer joins ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14813/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/14813/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1276 PS5, Line 1276: Pair<SlotRef, SlotRef> slotRefs = p.getEqSlotRefs(); Sorry to be unclear in the last comment. I mean we can use p.getEqSlots() here. After getting the SlotIds, get their TupleId by Analyzer#getTupleId(SlotId slotId). Then we don't need to add a new function getEqSlotRefs() in BinaryPredicate. -- To view, visit http://gerrit.cloudera.org:8080/14813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9521bd768c4b333069c34d5c1e11b10ea535827 Gerrit-Change-Number: 14813 Gerrit-PatchSet: 5 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2019 03:18:16 +0000 Gerrit-HasComments: Yes
