Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/14813 )
Change subject: IMPALA-9162: Do not apply inferred predicate to outer joins ...................................................................... Patch Set 6: (2 comments) Updated patch. http://gerrit.cloudera.org:8080/#/c/14813/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/14813/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1283 PS4, Line 1283: // additional testing we could potentially relax this. > Done There was also a bug here ..a 'break' statement which should not be there since we want to remove all such invalid predicates. I have removed it. I think I was doing some testing in the past and it got left over. http://gerrit.cloudera.org:8080/#/c/14813/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/14813/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1276 PS5, Line 1276: Pair<SlotId, SlotId> slots = p.getEqSlots(); > Sorry to be unclear in the last comment. I mean we can use p.getEqSlots() h Yes, makes sense. I can use the Analyzer's method. -- To view, visit http://gerrit.cloudera.org:8080/14813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9521bd768c4b333069c34d5c1e11b10ea535827 Gerrit-Change-Number: 14813 Gerrit-PatchSet: 6 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2019 04:09:21 +0000 Gerrit-HasComments: Yes
