Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/14813 )
Change subject: IMPALA-9162: Do not apply inferred predicate to outer joins ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14813/6/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/14813/6/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1201 PS6, Line 1201: analyzer.markConjunctsAssigned(preds); > I'm trying to convince myself that it's correct to mark the conjuncts as as I can certainly update the comments regarding it being safe to drop inferred predicates of certain types. The inferred predicates are only created during the analyzer.createEquivConjuncts() call on line 1204, so we cannot drop them before that. I agree that ideally we should not be generating the inferred conjuncts that don't qualify. I have done a few experiments with doing this sooner (also based on Quanlong's suggestion about value transfer graph ..see a prior review comment). In those cases I found quite a few Explain plan diffs which would take some time to investigate. So, given that this is an escalation, I took a conservative approach. I will do some more analysis. -- To view, visit http://gerrit.cloudera.org:8080/14813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9521bd768c4b333069c34d5c1e11b10ea535827 Gerrit-Change-Number: 14813 Gerrit-PatchSet: 6 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2019 19:40:40 +0000 Gerrit-HasComments: Yes
