Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 10: Sorry for the GVO failures. I made a mistake that 1234567890 is actually an INT. In Hive, there's an override of mask function that masks an INT value and return in INT. So mask_show_first_n(1234567890, 0, 'x', 'x', 'x', -1, '9') returns cast(999999999 as INT) = 1410065407 in Hive. It should return 999999999 in Impala since we only have override for returning BIGINT results. The previous test passes due to an overflow happens in codes (detected by the USAN failures). In patch set 7, I just fix the overflow in codes but forget to fix the tests. So the recent GVO still failed. In patch set 10, I use 12345678900 which is a BIGINT to test the overflow behavior. The type of the constant can be revealed by "select typeOf(12345678900)". Hope you can have another look. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2020 13:33:38 +0000 Gerrit-HasComments: No
