Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 10: Code-Review+1 (2 comments) Code looks good. http://gerrit.cloudera.org:8080/#/c/14963/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14963/10//COMMIT_MSG@63 PS10, Line 63: Also mention that we want the masking functions to be evaluated in the backed C++ logic rather than calling out to java UDFs. http://gerrit.cloudera.org:8080/#/c/14963/10/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/14963/10/be/src/exprs/mask-functions-ir.cc@44 PS10, Line 44: Please reference the hive class that these were derived from in the comments. -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2020 17:45:00 +0000 Gerrit-HasComments: Yes
