Anonymous Coward (498) has posted comments on this change. ( http://gerrit.cloudera.org:8080/15068 )
Change subject: WIP IMPALA-9242: Filter privileges before returning them to Sentry ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/Principal.java File fe/src/main/java/org/apache/impala/catalog/Principal.java: http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/Principal.java@85 PS1, Line 85: * Returns all privilege names for this principal, or an empty set of no privileges are "or an empty set of no privileges" should be "or an empty set if no privileges" http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java File fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java: http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java@196 PS1, Line 196: return (server_ == null || server_.equalsIgnoreCase(privilege.getServer_name())) the condition check logic is not correct. It should be (server_ == null || (server_.equalsIgnoreCase(privilege.getServer_name()) && (db_ == null || db_.equalsIgnoreCase(privilege.getDb_name()))); if server_ == null, always returns true. if server_match, return true if (db_ == null) or (db_ match) same for table check -- To view, visit http://gerrit.cloudera.org:8080/15068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecd4281368d1c9fe88cfe850ea725cd68895712e Gerrit-Change-Number: 15068 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Anonymous Coward (498) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2020 21:37:24 +0000 Gerrit-HasComments: Yes
