Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15068 )

Change subject: WIP IMPALA-9242: Filter privileges before returning them to 
Sentry
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java
File 
fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java:

http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java@110
PS2, Line 110:   public Set<String> listPrivileges(Set<String> groups, 
Set<String> users, ActiveRoleSet roleSet,
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java
File fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java:

http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java@200
PS2, Line 200:                  && (table_ == null || 
table_.equalsIgnoreCase(privilege.getTable_name()));
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/15068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd4281368d1c9fe88cfe850ea725cd68895712e
Gerrit-Change-Number: 15068
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Anonymous Coward (498)
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jan 2020 17:46:22 +0000
Gerrit-HasComments: Yes

Reply via email to